fix: improve standup media and live room emoji inputs#6038
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
LiveRoomContextand invoked it beforeAsk to speak,Join as speaker, andGo liveso browsers can request camera and microphone access togetherEmojiPickerdropdown rendering throughRootPortal, with outside-click handling and tests updated for the portaled dropdownWhy
Turning on camera and microphone separately in standups caused two permission prompts. The new preflight asks once at the stage-entry moment while keeping the existing toggle-level permission checks as a fallback.
The emoji picker changes keep the dropdown usable when rendered above surrounding overlays and restore emoji insertion in the live-room chat composer.
Impact
Hosts, moderated participants joining the queue, and free-for-all participants joining the stage should now see a single combined browser permission prompt in the common path to speaking. Live-room emoji pickers now render through the root portal and their tests match the real DOM structure.
Validation
node ./scripts/typecheck-strict-changed.jsNODE_ENV=test pnpm --filter shared test -- LiveRoomControls.spec.tsx LiveRoomContext.spec.tsxNODE_ENV=test pnpm --filter shared test -- EmojiPicker.spec.tsx LiveRoom.spec.tsxPreview domain
https://codex-standup-media-permissions.preview.app.daily.dev